From 1b37038d5a04d9ebd84431b36e9742bdb048b5a3 Mon Sep 17 00:00:00 2001 From: Coxxs <58-coxxs@users.noreply.git.ryujinx.app> Date: Tue, 24 Jun 2025 07:26:20 +0800 Subject: [PATCH] gdb: Log CommandReadMemory failure --- src/Ryujinx.HLE/Debugger/Debugger.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Ryujinx.HLE/Debugger/Debugger.cs b/src/Ryujinx.HLE/Debugger/Debugger.cs index 21bb32ec2..d32fa2c99 100644 --- a/src/Ryujinx.HLE/Debugger/Debugger.cs +++ b/src/Ryujinx.HLE/Debugger/Debugger.cs @@ -862,6 +862,9 @@ namespace Ryujinx.HLE.Debugger } catch (InvalidMemoryRegionException) { + // InvalidAccessHandler will show an error message, we log it again to tell user the error is from GDB (which can be ignored) + // TODO: Do not let InvalidAccessHandler show the error message + Logger.Notice.Print(LogClass.GdbStub, $"GDB failed to read memory at 0x{addr:X16}"); ReplyError(); } }