[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

src/Ryujinx.HLE/HOS/Services/Caps/CaptureManager.cs

@@ -11,19 +11,21 @@ namespace Ryujinx.HLE.HOS.Services.Caps
 {
     class CaptureManager
     {
-        private string _sdCardPath;
+        private readonly string _sdCardPath;
 
         private uint _shimLibraryVersion;
 
         public CaptureManager(Switch device)
         {
-            _sdCardPath = device.FileSystem.GetSdCardPath();
+            _sdCardPath = FileSystem.VirtualFileSystem.GetSdCardPath();
         }
 
         public ResultCode SetShimLibraryVersion(ServiceCtx context)
         {
-            ulong shimLibraryVersion   = context.RequestData.ReadUInt64();
+            ulong shimLibraryVersion = context.RequestData.ReadUInt64();
+#pragma warning disable IDE0059 // Remove unnecessary value assignment
             ulong appletResourceUserId = context.RequestData.ReadUInt64();
+#pragma warning restore IDE0059
 
             // TODO: Service checks if the pid is present in an internal list and returns ResultCode.BlacklistedPid if it is.
             //       The list contents needs to be determined.
@@ -82,28 +84,28 @@ namespace Ryujinx.HLE.HOS.Services.Caps
 
                 applicationAlbumEntry = new ApplicationAlbumEntry()
                 {
-                    Size              = (ulong)Unsafe.SizeOf<ApplicationAlbumEntry>(),
-                    TitleId           = titleId,
+                    Size = (ulong)Unsafe.SizeOf<ApplicationAlbumEntry>(),
+                    TitleId = titleId,
                     AlbumFileDateTime = new AlbumFileDateTime()
                     {
-                        Year     = (ushort)currentDateTime.Year,
-                        Month    = (byte)currentDateTime.Month,
-                        Day      = (byte)currentDateTime.Day,
-                        Hour     = (byte)currentDateTime.Hour,
-                        Minute   = (byte)currentDateTime.Minute,
-                        Second   = (byte)currentDateTime.Second,
-                        UniqueId = 0
+                        Year = (ushort)currentDateTime.Year,
+                        Month = (byte)currentDateTime.Month,
+                        Day = (byte)currentDateTime.Day,
+                        Hour = (byte)currentDateTime.Hour,
+                        Minute = (byte)currentDateTime.Minute,
+                        Second = (byte)currentDateTime.Second,
+                        UniqueId = 0,
                     },
-                    AlbumStorage      = AlbumStorage.Sd,
-                    ContentType       = ContentType.Screenshot,
-                    Padding           = new Array5<byte>(),
-                    Unknown0x1f       = 1
+                    AlbumStorage = AlbumStorage.Sd,
+                    ContentType = ContentType.Screenshot,
+                    Padding = new Array5<byte>(),
+                    Unknown0x1f = 1,
                 };
 
                 // NOTE: The hex hash is a HMAC-SHA256 (first 32 bytes) using a hardcoded secret key over the titleId, we can simulate it by hashing the titleId instead.
-                string hash       = Convert.ToHexString(SHA256.HashData(BitConverter.GetBytes(titleId))).Remove(0x20);
+                string hash = Convert.ToHexString(SHA256.HashData(BitConverter.GetBytes(titleId))).Remove(0x20);
                 string folderPath = Path.Combine(_sdCardPath, "Nintendo", "Album", currentDateTime.Year.ToString("00"), currentDateTime.Month.ToString("00"), currentDateTime.Day.ToString("00"));
-                string filePath   = GenerateFilePath(folderPath, applicationAlbumEntry, currentDateTime, hash);
+                string filePath = GenerateFilePath(folderPath, applicationAlbumEntry, currentDateTime, hash);
 
                 // TODO: Handle that using the FS service implementation and return the right error code instead of throwing exceptions.
                 Directory.CreateDirectory(folderPath);
@@ -131,4 +133,4 @@ namespace Ryujinx.HLE.HOS.Services.Caps
             return Path.Combine(folderPath, fileName);
         }
     }
-}
+}