[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

src/Ryujinx.HLE/HOS/Services/Caps/IScreenShotApplicationService.cs

@@ -20,14 +20,18 @@ namespace Ryujinx.HLE.HOS.Services.Caps
         public ResultCode SaveScreenShotEx0(ServiceCtx context)
         {
             // TODO: Use the ScreenShotAttribute.
+#pragma warning disable IDE0059 // Remove unnecessary value assignment
             ScreenShotAttribute screenShotAttribute = context.RequestData.ReadStruct<ScreenShotAttribute>();
 
-            uint  unknown              = context.RequestData.ReadUInt32();
+            uint unknown = context.RequestData.ReadUInt32();
+#pragma warning restore IDE0059
             ulong appletResourceUserId = context.RequestData.ReadUInt64();
-            ulong pidPlaceholder       = context.RequestData.ReadUInt64();
+#pragma warning disable IDE0059 // Remove unnecessary value assignment
+            ulong pidPlaceholder = context.RequestData.ReadUInt64();
+#pragma warning restore IDE0059
 
             ulong screenshotDataPosition = context.Request.SendBuff[0].Position;
-            ulong screenshotDataSize     = context.Request.SendBuff[0].Size;
+            ulong screenshotDataSize = context.Request.SendBuff[0].Size;
 
             byte[] screenshotData = context.Memory.GetSpan(screenshotDataPosition, (int)screenshotDataSize, true).ToArray();
 
@@ -43,20 +47,22 @@ namespace Ryujinx.HLE.HOS.Services.Caps
         public ResultCode SaveScreenShotEx1(ServiceCtx context)
         {
             // TODO: Use the ScreenShotAttribute.
-            ScreenShotAttribute screenShotAttribute = context.RequestData.ReadStruct<ScreenShotAttribute>();
+            _ = context.RequestData.ReadStruct<ScreenShotAttribute>();
 
-            uint  unknown              = context.RequestData.ReadUInt32();
+            _ = context.RequestData.ReadUInt32();
             ulong appletResourceUserId = context.RequestData.ReadUInt64();
-            ulong pidPlaceholder       = context.RequestData.ReadUInt64();
+
+            _ = context.RequestData.ReadUInt64();
 
             ulong applicationDataPosition = context.Request.SendBuff[0].Position;
-            ulong applicationDataSize     = context.Request.SendBuff[0].Size;
+            ulong applicationDataSize = context.Request.SendBuff[0].Size;
 
             ulong screenshotDataPosition = context.Request.SendBuff[1].Position;
-            ulong screenshotDataSize     = context.Request.SendBuff[1].Size;
+            ulong screenshotDataSize = context.Request.SendBuff[1].Size;
+
 
             // TODO: Parse the application data: At 0x00 it's UserData (Size of 0x400), at 0x404 it's a uint UserDataSize (Always empty for now).
-            byte[] applicationData = context.Memory.GetSpan(applicationDataPosition, (int)applicationDataSize).ToArray();
+            _ = context.Memory.GetSpan(applicationDataPosition, (int)applicationDataSize).ToArray();
 
             byte[] screenshotData = context.Memory.GetSpan(screenshotDataPosition, (int)screenshotDataSize, true).ToArray();
 
@@ -72,19 +78,20 @@ namespace Ryujinx.HLE.HOS.Services.Caps
         public ResultCode SaveScreenShotEx2(ServiceCtx context)
         {
             // TODO: Use the ScreenShotAttribute.
-            ScreenShotAttribute screenShotAttribute = context.RequestData.ReadStruct<ScreenShotAttribute>();
+            _ = context.RequestData.ReadStruct<ScreenShotAttribute>();
 
-            uint  unknown              = context.RequestData.ReadUInt32();
+            _ = context.RequestData.ReadUInt32();
             ulong appletResourceUserId = context.RequestData.ReadUInt64();
 
             ulong userIdListPosition = context.Request.SendBuff[0].Position;
-            ulong userIdListSize     = context.Request.SendBuff[0].Size;
+            ulong userIdListSize = context.Request.SendBuff[0].Size;
 
             ulong screenshotDataPosition = context.Request.SendBuff[1].Position;
-            ulong screenshotDataSize     = context.Request.SendBuff[1].Size;
+            ulong screenshotDataSize = context.Request.SendBuff[1].Size;
+
 
             // TODO: Parse the UserIdList.
-            byte[] userIdList = context.Memory.GetSpan(userIdListPosition, (int)userIdListSize).ToArray();
+            _ = context.Memory.GetSpan(userIdListPosition, (int)userIdListSize).ToArray();
 
             byte[] screenshotData = context.Memory.GetSpan(screenshotDataPosition, (int)screenshotDataSize, true).ToArray();
 
@@ -95,4 +102,4 @@ namespace Ryujinx.HLE.HOS.Services.Caps
             return resultCode;
         }
     }
-}
+}