Merge branch 'gdb-stub' into 'master'

Add GDB Stub

See merge request [ryubing/ryujinx!71](https://git.ryujinx.app/ryubing/ryujinx/-/merge_requests/71)

src/ARMeilleure/State/ExecutionContext.cs

@@ -153,7 +153,7 @@ namespace ARMeilleure.State
 
         public void StepHandler()
         {
-            _stepCallback?.Invoke(this);
+            _stepCallback.Invoke(this);
         }
 
         public void RequestDebugStep()
@@ -166,7 +166,7 @@ namespace ARMeilleure.State
         {
             if (Optimizations.EnableDebugging)
             {
-                DebugPc = Pc;
+                DebugPc = Pc; // TODO: Is this the best place to update DebugPc?
             }
 
             _breakCallback?.Invoke(this, address, imm);
@@ -176,7 +176,7 @@ namespace ARMeilleure.State
         {
             if (Optimizations.EnableDebugging)
             {
-                DebugPc = Pc;
+                DebugPc = Pc; // TODO: Is this the best place to update DebugPc?
             }
 
             _supervisorCallback?.Invoke(this, address, imm);

src/Ryujinx.Cpu/LightningJit/State/ExecutionContext.cs

@@ -1,4 +1,3 @@
-using ARMeilleure;
 using ARMeilleure.Memory;
 using ARMeilleure.State;
 using System;
@@ -128,7 +127,7 @@ namespace Ryujinx.Cpu.LightningJit.State
 
         public void StepHandler()
         {
-            _stepCallback?.Invoke(this);
+            _stepCallback.Invoke(this);
         }
 
         public void RequestDebugStep()
@@ -139,21 +138,11 @@ namespace Ryujinx.Cpu.LightningJit.State
 
         internal void OnBreak(ulong address, int imm)
         {
-            if (Optimizations.EnableDebugging)
-            {
-                DebugPc = Pc;
-            }
-
             _breakCallback?.Invoke(this, address, imm);
         }
 
         internal void OnSupervisorCall(ulong address, int imm)
         {
-            if (Optimizations.EnableDebugging)
-            {
-                DebugPc = Pc;
-            }
-
             _supervisorCallback?.Invoke(this, address, imm);
         }
 

src/Ryujinx.HLE/HOS/ArmProcessContextFactory.cs

@@ -69,7 +69,7 @@ namespace Ryujinx.HLE.HOS
                     mode = MemoryManagerMode.SoftwarePageTable;
                 }
 
-                ICpuEngine cpuEngine = isArm64Host && (mode == MemoryManagerMode.HostMapped || mode == MemoryManagerMode.HostMappedUnsafe) && !context.Device.Configuration.EnableGdbStub
+                ICpuEngine cpuEngine = isArm64Host && (mode == MemoryManagerMode.HostMapped || mode == MemoryManagerMode.HostMappedUnsafe)
                     ? new LightningJitEngine(_tickSource)
                     : new JitEngine(_tickSource);