From ac2c4ff3991331143edc564f820b02b4e7d30c52 Mon Sep 17 00:00:00 2001 From: Coxxs <58-coxxs@users.noreply.git.ryujinx.app> Date: Wed, 25 Jun 2025 03:28:17 +0800 Subject: [PATCH 1/2] gdb: Change HandleVContCommand comment --- src/Ryujinx.HLE/Debugger/Debugger.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Ryujinx.HLE/Debugger/Debugger.cs b/src/Ryujinx.HLE/Debugger/Debugger.cs index 015fbf8fb..872ca51cd 100644 --- a/src/Ryujinx.HLE/Debugger/Debugger.cs +++ b/src/Ryujinx.HLE/Debugger/Debugger.cs @@ -693,7 +693,7 @@ namespace Ryujinx.HLE.Debugger // If we receive "vCont;c", just continue the process. // If we receive something like "vCont;c:2e;c:2f" (IDA Pro will send commands like this), continue these threads. - // For "vCont;s:2f;c", we only step thread 2f, and do not continue other threads. (Is this correct?) + // For "vCont;s:2f;c", `DebugProcess.DebugStep()` will continue and suspend other threads if needed, so we don't do anything here. if (threadActionMap.Values.All(a => a.Action == VContAction.Continue)) { DebugProcess.DebugContinue(); From f7a0b17a073e3b2a0a4bbab46b3ee38d36fb8c9b Mon Sep 17 00:00:00 2001 From: Coxxs <58-coxxs@users.noreply.git.ryujinx.app> Date: Wed, 25 Jun 2025 03:46:28 +0800 Subject: [PATCH 2/2] gdb: Fix missing return --- src/Ryujinx.HLE/Debugger/Debugger.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Ryujinx.HLE/Debugger/Debugger.cs b/src/Ryujinx.HLE/Debugger/Debugger.cs index 872ca51cd..7a626b840 100644 --- a/src/Ryujinx.HLE/Debugger/Debugger.cs +++ b/src/Ryujinx.HLE/Debugger/Debugger.cs @@ -548,6 +548,7 @@ namespace Ryujinx.HLE.Debugger if (!BreakpointManager.SetBreakPoint(addr, len, false)) { ReplyError(); + return; } ReplyOK(); return; @@ -583,6 +584,7 @@ namespace Ryujinx.HLE.Debugger if (!BreakpointManager.ClearBreakPoint(addr, len)) { ReplyError(); + return; } ReplyOK(); return;